Improve performance of REPEAT functions #12015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <[email protected]>
Omega359
reviewed
Aug 16, 2024
Signed-off-by: Tai Le Manh <[email protected]>
Signed-off-by: Tai Le Manh <[email protected]>
tlm365
force-pushed
the
repeat-optimize
branch
from
d95992a to
230281c
Compare
alamb
reviewed
Aug 16, 2024
| (Some(_), Some(_)) => Some("".to_string()), | ||
| _ => None, | ||
| } | ||
| .for_each(|(string, number)| match (string, number) { |
alamb
reviewed
Aug 16, 2024
| @@ -251,6 +252,22 @@ impl<'a> ColumnarValueRef<'a> { | |||
| } | |||
| } | |||
|
|
|||
| pub trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized { | |||
There was a problem hiding this comment.
#12027 is a PR to document this trait and how to use it
alamb
approved these changes
Aug 16, 2024
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11990.
Rationale for this change
Refactor code and improve performance.
What changes are included in this PR?
repeatfunction and benchmark.Are these changes tested?
Yes
Are there any user-facing changes?
No
Benchmark stats on my local machine: