Fix Duration vs Interval comparisons and Interval as LHS
#11876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Thank you very much @samuelcolvin
I also filed #11891 to track this
| @@ -3109,6 +3109,43 @@ SELECT * FROM VALUES | |||
| 2024-02-01T08:00:00Z | |||
| 2023-12-31T23:00:00Z | |||
|
|
|||
| # interval vs. duration comparison | |||
There was a problem hiding this comment.
It might also be worth adding tests (could be in a follow on PR) for the other operators enabled in this PR
<=, =, !=, >, and >=
There was a problem hiding this comment.
I've added all cases here.
|
Thanks @samuelcolvin |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #11891
Rationale for this change
We regularly want to allow queries of the form
Until now that failed with
While working on that, I discovered you couldn't compare to an interval with the interval as the left hand side of the operation, so I fixed that too.
What changes are included in this PR?
Durationvs.Intervalcomparison - sense check - is it really as simple as it looks?Are these changes tested?
Yes
Are there any user-facing changes?
Should be only the above changes to support SQL.