Improve OOM message when a single reservation request fails to get more bytes. #11771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
andygrove
approved these changes
Aug 1, 2024
Dandandan
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11523
Rationale for this change
Improve the OOM error messages per here.
We have memory reservations, memory consumers, and a memory pool. The pool has many consumers, and each consumer can have many reservations. The code docs added in the previous PR make this delineation clear.
In this PR we changed the error message provided when we are comparing the pool vs reservation's request. We now explicitly define which bytes refer to the reservation vs the pool.
What changes are included in this PR?
Changes a single error message.
Are these changes tested?
Yes.
Are there any user-facing changes?
No API changes. Only less confusing error messages.