Ensure statistic defaults in parquet writers are in sync #11656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting is expected
…afusion_defaults twice (in both the original DF options and in the builder too); only should set once
…o true (default is false)
github-actions
bot
added
documentation
|
The clippy failure can likely be resolved by updating from main |
alamb
changed the title
alamb
approved these changes
Jul 26, 2024
| @@ -202,7 +202,7 @@ datafusion.execution.parquet.pruning true | |||
| datafusion.execution.parquet.pushdown_filters false | |||
| datafusion.execution.parquet.reorder_filters false | |||
| datafusion.execution.parquet.skip_metadata true | |||
| datafusion.execution.parquet.statistics_enabled NULL | |||
| datafusion.execution.parquet.statistics_enabled page | |||
There was a problem hiding this comment.
I think this is an improvement -- it doesn't change the default value (NULL means use arrow-rs defaults, which is page), but now the default value isexplicit in the config settings
Also there is a test to ensure the defaults don't drift from the arrow-rs defaults accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11367
Rationale for this change
Final step to ensure that all default configuration settings, between the parquet session options and the arrow writer options, remain in alignment.
What changes are included in this PR?
Doc that the compression defaults are intentionally different.
Make the
statistics_enableddefaults match.Fix the bloom filter tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.