Provide DataFrame API for map and move map to functions-array
#11560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Jul 20, 2024
|
|
||
| #[tokio::test] | ||
| async fn test_fn_map() -> Result<()> { | ||
| let expr = map(vec![lit("a"), lit("b"), lit("c")], vec![lit(1), lit(2), lit(3)]); |
There was a problem hiding this comment.
I expected the DataFrame user can use map like this.
goldmedal
force-pushed
the
feature/11546-map-df-api
branch
from
f43bd10 to
670e245
Compare
goldmedal
changed the title
mapmap and move map to functions-array
|
Can we also add |
alamb
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
I agree map makes sense to be in the functions-array crate. Thank you @goldmedal and @jayzhan211
|
Thanks @jayzhan211 and @alamb for reviewing! |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
…pache#11560) * move map to `functions-array` and implement dataframe api * add benchmark for dataframe api * fix format * add roundtrip_expr_api test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11546 .
Rationale for this change
What changes are included in this PR?
map().mapfunction is based onarray, I movedmaptofunctions-array. See more discussion in Easier Dataframe API formap#11546 (comment)Are these changes tested?
yes
Are there any user-facing changes?
Add a function