Minor: remove clones and unnecessary Arcs in from_substrait_rex
#11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/clean_substrait
branch
from
7745ce8 to
f2ea105
Compare
alamb
commented
Jul 8, 2024
| if new_name != name { | ||
| exprs.push(x.as_ref().clone().alias(new_name.clone())); | ||
| exprs.push(x.alias(new_name.clone())); |
There was a problem hiding this comment.
because the code returned Arc<Expr> previously, but most places in Expr need either Expr or Box<Expr> the code ended up copying the expressions unnecessarily
alamb
commented
Jul 8, 2024
| @@ -1069,9 +1065,7 @@ pub async fn from_substrait_rex( | |||
| input_schema, | |||
| extensions, | |||
| ) | |||
| .await? | |||
| .as_ref() | |||
There was a problem hiding this comment.
these clones are entirely uncessary
Blizzara
approved these changes
Jul 8, 2024
comphead
reviewed
Jul 10, 2024
| @@ -411,11 +411,11 @@ pub async fn from_substrait_rel( | |||
| from_substrait_rex(ctx, e, input.clone().schema(), extensions) | |||
| .await?; | |||
| // if the expression is WindowFunction, wrap in a Window relation | |||
| if let Expr::WindowFunction(_) = x.as_ref() { | |||
| if let Expr::WindowFunction(_) = &x { | |||
There was a problem hiding this comment.
I hoped clippy can find things like this 🤔
There was a problem hiding this comment.
For some reason, to convert an Arc<T> to &T you can't just do
let my_ref = &my_arc;Rust seems to require you to do
let my_ref = my_arc.as_ref();I don't really know the nuances as to why.
After this change, x is no longer an Arc<Expr> it is only an Expr which Rust is happier to auto-reference
comphead
approved these changes
Jul 10, 2024
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 12, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While reviewing #11329 from @Blizzara I was confused about the use of
Arc<Expr>: #11329 (comment)I looked into it more deeply and I found we can remove the
Arcand a bunch ofcloneinfrom_substrait_rexThis not only makes the code simpler, it is also more efficient.
What changes are included in this PR?
Return
Result<Expr>rather thanResult<Arc<Expr>>when creating DataFusion structures from substrait REX, and avoid unecessary copies theArcwas requiringAre these changes tested?
Existing CI
Are there any user-facing changes?