Use upstream DataType::from_str in arrow-cast
#11254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 3, 2024
| } | ||
| } | ||
| } | ||
| val.parse().map_err(|e| match e { |
There was a problem hiding this comment.
Simply use the upstream impl now
alamb
force-pushed
the
alamb/remove_datatype_parse
branch
from
e52703f to
54f6587
Compare
|
I also double checked that it has support for |
alamb
changed the title
DataType::from_str in arrow-cast
comphead
reviewed
Jul 31, 2024
comphead
reviewed
Jul 31, 2024
comphead
reviewed
Jul 31, 2024
Co-authored-by: Oleks V <[email protected]>
…sion into alamb/remove_datatype_parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until apache/arrow-rs#5994 is released (likely52.2.0)Which issue does this PR close?
N/A
Rationale for this change
@samuelcolvin ported this code upstream to arrow-rs in apache/arrow-rs#5994 so let's use that code
What changes are included in this PR?
Remove DataType parsing code in DataFusion and use upstreamed copy
Are these changes tested?
Are there any user-facing changes?