Support to unparse TimestampSecond and TimestampMicrosecond to String
#11120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Thank you (again) for this very nice contribution @goldmedal
| ))?.to_string() | ||
| }; | ||
| self.timestamp_string_to_sql(result) | ||
| self.handle_timestamp::<TimestampMillisecondType>(v, tz) |
There was a problem hiding this comment.
It is a very nice refactor to move this code into its own function. ❤️
goldmedal
force-pushed
the
feature/unparse-timstamp
branch
from
a455305 to
bfb6521
Compare
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…ring (apache#11120) * support to unparse TimestampSecond and TimestampMicrosecond * cargo fmt * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
The follow-up of #11046 and #10984. Part of #9494
Rationale for this change
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?
no