Add standalone example for OptimizerRule
#11087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 23, 2024
| @@ -402,6 +402,16 @@ impl SessionState { | |||
| self | |||
| } | |||
|
|
|||
| // the add_optimizer_rule takes an owned reference | |||
There was a problem hiding this comment.
I noticed the naming in SessionState is pretty inconsistent
| /// Adds an analyzer rule to the end of the existing rules. | ||
| /// | ||
| /// See [`SessionState`] for more control of when the rule is applied. | ||
| pub fn add_analyzer_rule(&self, analyzer_rule: Arc<dyn AnalyzerRule + Send + Sync>) { |
comphead
reviewed
Jun 24, 2024
| // +--------+-----+ | ||
| // | Andy | 11 | | ||
| // | Andrew | 22 | | ||
| // | Oleks | 33 | |
comphead
reviewed
Jun 24, 2024
Co-authored-by: Oleks V <[email protected]>
github-actions
bot
removed
the
documentation
|
🚀 |
findepi
reviewed
Jul 2, 2024
| /// [`OptimizerRule`]s transform [`LogicalPlan`]s into an equivalent (but | ||
| /// hopefully faster) form. | ||
| /// | ||
| /// See [analyzer_rule.rs] for an example of AnalyzerRules, which are for |
There was a problem hiding this comment.
is analyzer_rule.rs a file in the repo?
There was a problem hiding this comment.
It will be once I can get someone to approve #11089
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Add standalone example for `OptimizerRule` * Fix typo * Update datafusion-examples/examples/optimizer_rule.rs Co-authored-by: Oleks V <[email protected]> * fmt --------- Co-authored-by: Oleks V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10855
Rationale for this change
The current
rewrite_expr.rsexample has three distinct examples:AnalyzerRuleOptimizerRuleEach I think should be its own example to make them easier to find and more full featured
What changes are included in this PR?
optimizer_rule.rsSessionContext::add_optimizer_ruleas a convenience&mut selfto be consistentAre these changes tested?
Yes, by CI test on examples