Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate error instead of panicking on out of bounds in physical-expr/src/analysis.rs #10992

Merged
merged 2 commits into from
Jun 20, 2024
Merged

propagate error instead of panicking on out of bounds in physical-expr/src/analysis.rs #10992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce3576
propogate error instead of panicking
LorrensP-2158466 Jun 19, 2024
9080fc2
use macro for creating internal df error
LorrensP-2158466 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions datafusion/physical-expr/src/analysis.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ use crate::PhysicalExpr;

use arrow::datatypes::Schema;
use datafusion_common::stats::Precision;
use datafusion_common::{internal_err, ColumnStatistics, Result, ScalarValue};
use datafusion_common::{
internal_datafusion_err, internal_err, ColumnStatistics, Result, ScalarValue,
};
use datafusion_expr::interval_arithmetic::{cardinality_ratio, Interval};

/// The shared context used during the analysis of an expression. Includes
Expand Down Expand Up @@ -92,7 +94,13 @@ impl ExprBoundaries {
col_stats: &ColumnStatistics,
col_index: usize,
) -> Result<Self> {
let field = &schema.fields()[col_index];
let field = schema.fields().get(col_index).ok_or_else(|| {
internal_datafusion_err!(
"Could not create `ExprBoundaries`: in `try_from_column` `col_index`
has gone out of bounds with a value of {col_index}, the schema has {} columns.",
schema.fields.len()
)
})?;
let empty_field =
ScalarValue::try_from(field.data_type()).unwrap_or(ScalarValue::Null);
let interval = Interval::try_new(
Expand Down