Fix FormatOptions::CSV propagation
#10912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this contribution @svranesevic Can you perhaps add a test for this feature? Maybe in |
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
github-actions
bot
added
core
alamb
approved these changes
Jun 22, 2024
|
I merged up from main and updated the vendored code in this PR |
|
Thanks again @svranesevic 🚀 |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Fix sink output schema being passed in to `FileSinkExec` where input schema was expected * Propagate CSV options (quote, double quote, and escape) through protos * Add test for double quotes * Test quote escape when double quotes are disabled * regen --------- Co-authored-by: svranesevic <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
/
Rationale for this change
Noticed while using
LogicalPlan::CopywithFormatOptions::CSVthatescapeandquoteoptions were not reflected in resulting CSV file.What changes are included in this PR?
Fix some of the
FormatOptions::CSV(CsvOptions)not being propagated to/from protos - 75a9b4cAdd
double_quotetoCsvOptionsoptions - 75a9b4cFix wrong schema passed in to
DataSinkExecwhen decodingJsonSink,CsvSink, andParquetSink- 65ad9b6Are these changes tested?
First time contributor, would need guidance how/if to test these best.
Are there any user-facing changes?
double_quotetoCsvOptionsoptions - 75a9b4c