fix: array_slice panics
#10547
Merged
fix: array_slice panics
#10547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
May 16, 2024
| let stride = stride.unwrap_or(1); | ||
| if stride.is_zero() { | ||
| return exec_err!( | ||
| "array_slice got invalid stride: {:?}, it cannot be 0", | ||
| stride | ||
| ); | ||
| } else if from <= to && stride.is_negative() { | ||
| } else if (from <= to && stride.is_negative()) |
There was a problem hiding this comment.
When from is equal to to, it should not return an empty list.
The fix for it is not included in this PR, it has been added to issue #10548.
alamb
approved these changes
May 16, 2024
|
Thank you for reviewing @alamb |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* fix: array_slice panics * add test * add test * update test * fix comment * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10425.
Rationale for this change
Note: Negative
fromortoimplies counting from the end of the list and both are standardized to the corresponding positive index.When
fromis greater thantoandstrideis a positive, the following loop becomes infinite, until theindexbecomes excessively large and panics.datafusion/datafusion/functions-array/src/extract.rs
Lines 468 to 478 in 842f393
The fix is to return an empty list directly in this situation.
What changes are included in this PR?
Fix panic.
Are these changes tested?
Yes
Are there any user-facing changes?
No