Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on LogicalPlan TreeNode methods #10037

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 10, 2024

Which issue does this PR close?

Part of #8913 and part of #7013

Rationale for this change

The TreeNode API has everything we need, but finding the right methods is sometimes challenging. Along with #10035 I think this will make it easier to use

What changes are included in this PR?

  1. Add more docs
  2. No functional changes

Are these changes tested?

CI

Are there any user-facing changes?

No functional changes

@alamb alamb added the documentation Improvements or additions to documentation label Apr 10, 2024
@alamb
Copy link
Contributor Author

alamb commented Apr 10, 2024

FYI @peter-toth

@github-actions github-actions bot added logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels Apr 10, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit f55c1d9 into apache:main Apr 11, 2024
24 checks passed
appletreeisyellow pushed a commit to influxdata/arrow-datafusion that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants