Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct_on to dataframe api #11011

Closed
Omega359 opened this issue Jun 19, 2024 · 1 comment · Fixed by #11012
Closed

Add distinct_on to dataframe api #11011

Omega359 opened this issue Jun 19, 2024 · 1 comment · Fixed by #11012
Assignees
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Is your feature request related to a problem or challenge?

The dataframe api has a distinct(self) function however it's missing a distinct_on equivalent that is available in the logical plan. DISTINCT ON is available for use via sql and this issue is to add the equivalent to the dataframe api.

Describe the solution you'd like

A new function distinct_on( self, on_expr: Vec<Expr>, select_expr: Vec<Expr>, sort_expr: Option<Vec<Expr>>, ) -> Result<DataFrame>
added to the dataframe api.

Describe alternatives you've considered

No response

Additional context

No response

@Omega359 Omega359 added the enhancement New feature or request label Jun 19, 2024
@Omega359
Copy link
Contributor Author

take

Omega359 added a commit to Omega359/arrow-datafusion that referenced this issue Jun 19, 2024
alamb added a commit that referenced this issue Jun 21, 2024
* Add distinct_on to dataframe api #11011

* cargo fmt

* Update datafusion/core/src/dataframe/mod.rs as per reviewer feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this issue Jun 22, 2024
* Add distinct_on to dataframe api apache#11011

* cargo fmt

* Update datafusion/core/src/dataframe/mod.rs as per reviewer feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this issue Jun 22, 2024
* Add distinct_on to dataframe api apache#11011

* cargo fmt

* Update datafusion/core/src/dataframe/mod.rs as per reviewer feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
findepi pushed a commit to findepi/datafusion that referenced this issue Jul 16, 2024
* Add distinct_on to dataframe api apache#11011

* cargo fmt

* Update datafusion/core/src/dataframe/mod.rs as per reviewer feedback

Co-authored-by: Andrew Lamb <[email protected]>

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant