Skip to content

Commit

Permalink
Run CI with latest (Rust 1.80), add ticket references to commented ou…
Browse files Browse the repository at this point in the history
…t tests (#11661)

* Revert "Temporarily pin toolchain version to avoid clippy (#11655)"

This reverts commit 5b7e0aa.

* Add ticket references in comments
  • Loading branch information
alamb authored Jul 26, 2024
1 parent cdf387e commit 01dc3f9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 20 deletions.
3 changes: 3 additions & 0 deletions datafusion/physical-plan/src/joins/hash_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1932,6 +1932,7 @@ mod tests {
}

// FIXME(#TODO) test fails with feature `force_hash_collisions`
// https://github.com/apache/datafusion/issues/11658
#[cfg(not(feature = "force_hash_collisions"))]
#[apply(batch_sizes)]
#[tokio::test]
Expand Down Expand Up @@ -1989,6 +1990,7 @@ mod tests {

/// Test where the left has 2 parts, the right with 1 part => 1 part
// FIXME(#TODO) test fails with feature `force_hash_collisions`
// https://github.com/apache/datafusion/issues/11658
#[cfg(not(feature = "force_hash_collisions"))]
#[apply(batch_sizes)]
#[tokio::test]
Expand Down Expand Up @@ -2103,6 +2105,7 @@ mod tests {

/// Test where the left has 1 part, the right has 2 parts => 2 parts
// FIXME(#TODO) test fails with feature `force_hash_collisions`
// https://github.com/apache/datafusion/issues/11658
#[cfg(not(feature = "force_hash_collisions"))]
#[apply(batch_sizes)]
#[tokio::test]
Expand Down
1 change: 1 addition & 0 deletions datafusion/sqllogictest/test_files/parquet.slt
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ SELECT COUNT(*) FROM timestamp_with_tz;
131072

# FIXME(#TODO) fails with feature `force_hash_collisions`
# https://github.com/apache/datafusion/issues/11660
# Perform the query:
# query IPT
# SELECT
Expand Down
1 change: 1 addition & 0 deletions datafusion/sqllogictest/test_files/sort_merge_join.slt
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ SELECT * FROM t1 FULL JOIN t2 ON t1_id = t2_id
NULL NULL NULL 55 w 3

# FIXME(#TODO) fails with feature `force_hash_collisions`
# https://github.com/apache/datafusion/issues/11659
# equijoin_full_and_condition_from_both
# query ITIITI rowsort
# SELECT * FROM t1 FULL JOIN t2 ON t1_id = t2_id AND t2_int <= t1_int
Expand Down
20 changes: 0 additions & 20 deletions rust-toolchain.toml

This file was deleted.

0 comments on commit 01dc3f9

Please sign in to comment.