Add support for DROP EXTENSION #1610
Merged
+144
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` DROP EXTENSION [ IF EXISTS ] name [, ...] [ CASCADE | RESTRICT ] ``` https://www.postgresql.org/docs/current/sql-dropextension.html
ramnivas
added a commit
to exograph/exograph
that referenced
this pull request
Dec 19, 2024
Our migration tests have used strings in Rust files (for exo and expected SQL), which required string escaping, prefix stripping, and other modifications. This made it difficult to read and extend the test code (for example, consider `MigrationScope`s). Also, we relied on exact string matches, which required paying too much attention to the precise format. This refactoring: 1. Move .exo and .sql files outside of rust code 2. Use `sqlparser` to match without considering the format Note that in some cases, `sqlparser` doesn't parse valid syntax, so we rely on exact string comparison as a fallback/optimization. We have already contributed a couple of changes (apache/datafusion-sqlparser-rs#1608, apache/datafusion-sqlparser-rs#1610) and will continue to do so to remove this reliance.
iffyio
reviewed
Dec 19, 2024
| @@ -2759,6 +2759,15 @@ pub enum Statement { | |||
| version: Option<Ident>, | |||
| }, | |||
| /// ```sql | |||
| /// DROP EXTENSION [ IF EXISTS ] name [, ...] [ CASCADE | RESTRICT ] | |||
| /// ``` | |||
There was a problem hiding this comment.
Could we also include the link in the description here? would help folks find the syntax quicker in the future if needed
| @@ -5861,6 +5863,22 @@ impl<'a> Parser<'a> { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn parse_drop_extension(&mut self) -> Result<Statement, ParserError> { | |||
There was a problem hiding this comment.
Since the function is being made a public function, could we include a description for it?
src/parser/mod.rs
Outdated
| cascade_or_restrict: cascade_or_restrict.map(|k| match k { | ||
| Keyword::CASCADE => ReferentialAction::Cascade, | ||
| Keyword::RESTRICT => ReferentialAction::Restrict, | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
in place of panicking here in case we missed something/bug, we can return an explicit error return self.expected(..)?
tests/sqlparser_postgres.rs
Outdated
| @@ -662,6 +662,22 @@ fn parse_create_extension() { | |||
| .verified_stmt("CREATE EXTENSION extension_name WITH SCHEMA schema_name VERSION version"); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_drop_extension() { | |||
| pg_and_generic().verified_stmt("DROP EXTENSION extension_name"); | |||
There was a problem hiding this comment.
Since the feature introduces a new node to the ast can we add one scenario that asserts the ast in this style?
There was a problem hiding this comment.
Done, but in a slightly different style (more succinct), and did so for all scenarios.
iffyio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.postgresql.org/docs/current/sql-dropextension.html