Avoid cloning during token creation #1603
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Inspired by @davisp's #1591 I was looking at
Token::make_word
and I noticed it made 2 clones (owned strings). Each copy slows things down so let's avoid themChanges
Token::make_word
to reuse its argument and thus save a cloneAPI Changes
This changes Token::make_word and Token::make_keyword to take
String
instead of&str
. This would be a breaking API change. If it is a problem I can make owned variants (likeToken::make_word_owned
or something) 🤔Performance benchmarks:
🤔 it appears not to make much/any difference