Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake, Databricks, Postgres, and others all support some from of table sampling.
This commonly takes on the form
where
Different dialects support one, the other, or both sample keywords and only some of the methods. The current PR follows the snowflake paradigm.
Outstanding questions
Parser
code would make me think it should be part of theparse_table_factor()
logic since it always trails a relation. However this would then require each variant ofTableFactor
that supportsSAMPLE
to have a placeholder for it. Is that the right approach?