Feat: Support array_join #1290
Open
Feat: Support array_join #1290
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenavsarogullari
force-pushed
the
array_join
branch
from
b98415e to
5d3c94d
Compare
SteNicholas
reviewed
Jan 15, 2025
| @@ -86,6 +86,7 @@ message Expr { | |||
| ArrayInsert array_insert = 59; | |||
| BinaryExpr array_contains = 60; | |||
| BinaryExpr array_remove = 61; | |||
| BinaryExpr array_join = 63; | |||
There was a problem hiding this comment.
I have another PR for array_intersect and it uses 62. I think array_intersect can go first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to Epic: #1042
array_join:select array_join(array('hello', '-', 'world'), ' ')=>hello - worldDataFusion' s
array_joinfunction is alias of array_to_string function:https://datafusion.apache.org/user-guide/sql/scalar_functions.html#array-join
Rationale for this change
Defined under Epic: #1042
What changes are included in this PR?
planner.rs:Created DataFusionarray_joinphysical expression from Spark physical expression with return type:DataType::Utf8,expr.proto:array_joinmessage has been added (array_intersect is 62),QueryPlanSerde.scala:array_joinpattern matching case has been added,CometExpressionSuite.scala:A new UT has been added forarray_joinfunction.How are these changes tested?
A new UT has been added and first query result is as follows:
