Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HasRowIdMapping interface #1288

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 14, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

Iceberg's CometVector has delete support which has an internal row id mapping to skip some rows in a batch. We need an API in Comet to get the row id mapping from third-party CometVector implementation like that.

What changes are included in this PR?

How are these changes tested?

@viirya viirya requested a review from huaxingao January 14, 2025 23:07
* Position delete 2, 6
* [0,1,3,4,5,7,-,-] -- After applying position deletes [Set Num records to 6]
*/
public interface HasRowIdMapping {
Copy link
Member Author

@viirya viirya Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iceberg's CometVector can implement this interface to provide rowIdMapping to Comet. cc @huaxingao

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit 82022af into apache:main Jan 15, 2025
75 checks passed
@viirya
Copy link
Member Author

viirya commented Jan 15, 2025

Thanks @huaxingao

@viirya viirya deleted the row_id_map_api branch January 15, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants