fix: cast timestamp to decimal is unsupported #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wForget
commented
Jan 14, 2025
| @@ -838,8 +838,9 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| castTest(generateTimestamps(), DataTypes.DoubleType) | |||
| } | |||
|
|
|||
| test("cast TimestampType to DecimalType(10,2)") { | |||
| castTest(generateTimestamps(), DataTypes.TimestampType) | |||
There was a problem hiding this comment.
@andygrove This test case introduced in #356 looks incorrect. Could you please take a look?
|
There is a test failure: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
=============================================
+ Coverage 34.69% 57.47% +22.78%
+ Complexity 991 961 -30
=============================================
Files 116 113 -3
Lines 44891 11171 -33720
Branches 9864 2137 -7727
=============================================
- Hits 15574 6421 -9153
+ Misses 26168 3637 -22531
+ Partials 3149 1113 -2036 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1280.
Rationale for this change
What changes are included in this PR?
Fix test case and mark cast timestamp to decimal as unsupported.
How are these changes tested?
unit test