fix: handle loading of complex types into CometVector correctly in iceberg_compat scans #1279
+42
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eberg_compat scans
|
The PR also replaces the use of ColumnDescriptor (again valid only for primitive types) with parquet.schema.Type in NativeBatchReader |
parthchandra
commented
Jan 14, 2025
| // release the previous dictionary vector and create a new one. | ||
| Dictionary arrowDictionary = importer.getProvider().lookup(dictionaryEncoding.getId()); | ||
| CometPlainVector dictionaryVector = | ||
| new CometPlainVector(arrowDictionary.getVector(), useDecimal128, isUuid); |
There was a problem hiding this comment.
This is valid only for primitive types
| @@ -266,7 +268,8 @@ public void init() throws URISyntaxException, IOException { | |||
|
|
|||
| //// Create Column readers | |||
| List<ColumnDescriptor> columns = requestedSchema.getColumns(); | |||
| int numColumns = columns.size(); | |||
There was a problem hiding this comment.
This yields leaf fields which is not what we want.
| @@ -469,19 +473,23 @@ private int loadNextBatch() throws Throwable { | |||
| importer = new CometSchemaImporter(ALLOCATOR); | |||
|
|
|||
| List<ColumnDescriptor> columns = requestedSchema.getColumns(); | |||
| for (int i = 0; i < columns.size(); i++) { | |||
There was a problem hiding this comment.
This also operates on leaf fields which, again, is not what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeColumnReader was reading all types into a CometPlainVector which is correct only for primitive types. The PR updates the code to use NativeUtil and follow the same logic as CometExecIterator.
This addresses 12 unit test failures involving ColumnarShuffle on struct types.