Nodejs 10 #1237
Closed
Nodejs 10 #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willholley
force-pushed
the
nodejs-10
branch
4 times, most recently
from
d7b6403 to
a035b2e
Compare
|
I haven't been able to reproduce the error addressed by #1233 here - Travis shows the peerDependencies warning that I see locally but doesn't error. |
CouchDB Docker images now use nodejs 10 by default. This commit updates Travis to use nodejs 10 when running integration tests. It also adds and `npm ls` check which will fail if there are unmet peer dependencies in package.json.
|
Invalid peer dependencies now fail the build. However, failed builds cannot be merged so I'm going to combine this PR with the fix in #1233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add NodeJS 10 testing to Travis builds
Testing recommendations
N/A
GitHub issue number
#1234
Related Pull Requests
#1233 - we should be able to catch this error.
Checklist