Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): implementation structure #200

Merged
merged 1 commit into from
Jun 26, 2020
Merged

fix(windows): implementation structure #200

merged 1 commit into from
Jun 26, 2020

Conversation

janpio
Copy link
Member

@janpio janpio commented May 3, 2019

The Windows implementation was in a strange location in www, moved it to src like all the other platform implementations.

Also removes the wp platform and fixes tiny things in plugin.xml and package.json.

TODO:

  • Check if this is a breaking change or can be done in a minor update.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - also the breaking change was done in #143, so IHMO this is a patch/minor release since you just cleaned-up some forgotten files.

@janpio
Copy link
Member Author

janpio commented May 5, 2019

The "breaking" comment mainly referred to the moving of www/windows/SplashScreenProxy.js to src/windows/SplashScreenProxy.js. At first I was not sure if anythign external could rely on the file being in this location.

What do you refer to in #143?

@timbru31
Copy link
Member

timbru31 commented May 5, 2019

The "breaking" comment mainly referred to the moving of www/windows/SplashScreenProxy.js to src/windows/SplashScreenProxy.js. At first I was not sure if anythign external could rely on the file being in this location.

I personally doubt that anything external relies on this. At least not in a supported/intended way (of course you can always manually modify files in the your node_modules/platforms folder...)

What do you refer to in #143?

I referred to the removal of the wp8 platform

@erisu erisu force-pushed the janpio-fix_windows branch from aa71f28 to 01b2e8c Compare June 26, 2020 10:37
@erisu erisu changed the title Fix windows implementation fix(windows): implementation structure Jun 26, 2020
@erisu erisu added this to the 6.0.0 milestone Jun 26, 2020
@erisu erisu force-pushed the janpio-fix_windows branch from 01b2e8c to 25f2ece Compare June 26, 2020 11:56
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up this PR to be focused on the single original goal by splitting out other changes.

This PR now LGTM 👍

I will merge this in after the CI service finishes running.

@erisu erisu merged commit 050f29c into master Jun 26, 2020
@erisu erisu deleted the janpio-fix_windows branch June 26, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants