Fix #248 delete javascript reference to released media #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbru31
requested changes
Apr 2, 2020
timbru31
approved these changes
Apr 3, 2020
primerib
added a commit
to primerib/cordova-plugin-media
that referenced
this pull request
Jun 12, 2020
uaza
pushed a commit
to quiply/cordova-plugin-media
that referenced
this pull request
Oct 22, 2020
) Co-authored-by: Nate Dudenhoeffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All (www change)
Motivation and Context
This removes the javascript reference to released media objects. See #248
Description
Add a success callback to delete media id after it is released by platform specific code.
Checklist
(platform)if this change only applies to one platform (e.g.(android))