Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert jshint to eslint #234

Closed
wants to merge 3 commits into from
Closed

Convert jshint to eslint #234

wants to merge 3 commits into from

Conversation

GedasGa
Copy link

@GedasGa GedasGa commented Jun 18, 2019

Motivation and Context

Resolves #233

Description

More info: apache/cordova#123

Testing

npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • ~~ I added automated test coverage as appropriate for this change ~~
  • ~~ Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android)) ~~
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • ~~ I've updated the documentation if necessary~~

@GedasGa GedasGa force-pushed the convert-to-eslint branch from 1c97b2c to 97c5db9 Compare June 18, 2019 06:36
janpio
janpio reviewed Jun 18, 2019
View reviewed changes
tests/tests.js Outdated Show resolved Hide resolved
@GedasGa @janpio
Update tests/tests.js
8592193 
Co-Authored-By: Jan Piotrowski <[email protected]>
@timbru31 timbru31 mentioned this pull request Jul 4, 2020
Merged
@timbru31 timbru31 closed this in #283 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert to eslint
2 participants
@GedasGa @janpio