Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): Add error call for stalled_playback #195

Merged
merged 1 commit into from
May 23, 2022
Merged

feat(ios): Add error call for stalled_playback #195

merged 1 commit into from
May 23, 2022

Conversation

BuddyLReno
Copy link
Contributor

Platforms affected

  • iOS

What does this PR do?

  • Adds an error call for stalled playback on iOS.

What testing has been done on this change?

Physical device testing on:

  • iPhone X (iOS 12)
  • iPhone 6 (iOS 11)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@BuddyLReno BuddyLReno mentioned this pull request Nov 15, 2018
Closed
3 tasks
@pedrofurtado
Copy link

@DiegoZurita the PR that saves our day! Someone give please a oscar to that guy 🍻

erisu
erisu approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 512d3c4 into apache:master May 23, 2022
@erisu erisu changed the title Add error call for stalled_playback (iOS only) feat(ios): Add error call for stalled_playback May 24, 2022
@erisu erisu added this to the 6.0.0 milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
enhancement platform: ios
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BuddyLReno @pedrofurtado @erisu @janpio