feat(ios): explicitly import headers #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is important in Swift projects, where you cannot use prefix headers.
alekop
changed the title
erisu
changed the title
pesi-hgc
pushed a commit
to pesi-hgc/cordova-plugin-inappbrowser-transparent
that referenced
this pull request
Nov 3, 2023
… This is important in Swift projects, where you cannot use prefix headers. (apache#927) Co-authored-by: Aleko Petkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependencies, instead of relying on PCH files. This is important in Swift projects, where you cannot use prefix headers.
Platforms affected
iOS
Motivation and Context
Cannot add plugin to Swift-based project with embedded WKWebView, because it relies on prefix header, which is not supported in Swift projects.
Description
Explicitly import needed files, so we don't need to rely on PCH files.
Testing
Built successfully in ObjC and Swift based projects.
Checklist
(platform)if this change only applies to one platform (e.g.(android))