Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): apply PR#672 to uiwebview. #723

Closed
wants to merge 1 commit into from
Closed

Conversation

isdh
Copy link

@isdh isdh commented Jun 11, 2020

Platforms affected

iOS

Motivation and Context

I need to use uiwebview on iOS13. In spite of designate landscape mode only, StatusBar somehow orientate as portrait.
I found #672 that resolved wkwebview's StatusBar strange behavior.
but #672 didn't apply to uiwebview. And removed uiwebview on 4.0.x branch.

Description

apply #672 to uiwebview.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@jcesarmobile
Copy link
Member

thanks for the PR, but we don't apply fixes to old versions of plugins, only in the case of security problems, if you need that fix you can create a fork and maintain it for yourself.
Also, UIWebView is deprecated and Apple doesn't allow to use it in new apps since April and won't allow it in existing apps in December, so you should not use it.

@isdh
Copy link
Author

isdh commented Jun 17, 2020

@jcesarmobile
OK. thanks for comment. I'll maintain this fix in my repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants