-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solving issue #417 generated a new issue for inappbrowser when using usewkwebview=yes #424
Comments
OK, I see the problem here. My fix for #417 is screwing up sites using iframes (such as Trivago) because it's also redirecting those cross-frame requests back to the main IAB frame. |
Hello @dpa99c Regards |
@mosababubakr I have created PR #425 which should resolve this issue and also preserve the fix for #417. Please could you test the changes on my branch and confirm they resolve all your issues before this PR is merged to master. To install the plugin direct from my branch, you can use:
@janpio would be good to have some wider testing of this before it gets merged to confirm no other regression bugs have been introduced. |
Hello @dpa99c Thanks Just now we wait for the master version to merge and fix these issue. Regards |
@janpio @dpa99c @agrieve @stevengill @shazron @purplecabbage @timbru31 @sgrebnov
(After the old issue #417 solved , there is a new issue appear in inappbrowser load errors if you open any websites. and warning messages appear from header).
When @janpio @dpa99c edited the code to resolve #417 issue, there a new issue generated.
Please check inappbrowser plugin master version and try to open any website inside inappbrowser using usewkwebview=yes, and you will see that you can't see the websites.
You can try to open: https://www.trivago.com/ in inappbrowser as an example.
Before solving issue #417 , this new issue not appear, it is just appear after issue #417 solved.
Please check
Thanks.
Regards.
The text was updated successfully, but these errors were encountered: