-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): add bundled resources for privacy manifest #621
Conversation
db860b3
to
cdb8423
Compare
@erisu Thanks for this! Do you plan on releasing this change anytime soon? For regulatory reasons it's easier for us to use release versions than development versions. |
@jkronborg I pushed a release vote today. Cordova's voting process requires a 2+1 positive binding vote to be considered successful. Additionally, the process must remain open for a minimum of 48 hours. Depending on people's availability and the results, it is possible that we will see an official release shortly. You can monitor the vote via our dev mailing list: https://lists.apache.org/thread/fkdrny5yzjrqcmcc0ls4l25kngo311n9 |
@erisu Thanks 👍
|
The comment you linked should not be valid anymore. At that time we were thinking plugin developers would include the same privacy manifest tag structure in plugin.xml and Cordova would merge them together but that is not actually necessary. Xcode automatically detects and collects the privacy manifest files from the app, resource bundle, and frameworks/libraries and generates the report. The way this PR implemented the privacy manifest for plugins is preferred for other plugins. If a plugin is not updated, then app developers would need to determine the privacy information and include it in the app's config.xml. |
@erisu OK, thanks for the clarification. |
So to clarify, all I need to do to make Apple happy is update the plugin to 8.1.0? I don't need to add the privacy manifest to config.xml as well? |
file plugin 8.1 provides a bundled privacy manifest that declares what this plugin uses. Other plugins may do the same. If a plugin doesn't and uses an API that requires a declared reason, then you may have to resort to adding a In otherwords if the only plugin you use is file plugin, then yes 8.1 should satisfy Apple's requirements. We cannot speak for other plugins that might be installed in your project. |
Platforms affected
ios
Motivation and Context
Support Apple's Privacy Manifest requirements
closes #620
Description
PrivacyInfo.xcprivacy
to the resource bundleresource-file
inplugin.xml
The bundle is prefixed with Cordova's internal
CDV
namespace.Note for third-party plugins: When creating a bundle or even class names, it is recommended to establish your own namespace and utilize a unique identifier to prevent conflicts with other plugins.
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)