Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove WRITE_EXTERNAL_STORAGE permission from plugin.xml #556

Conversation

knight9999
Copy link
Contributor

@knight9999 knight9999 commented Jan 22, 2023

Platforms affected

Android

Motivation and Context

WRITE_EXTERNAL_STORAGE permission brings build error at Android SDK 33.

closes #543
closes #243

Description

Remove WRITE_EXTERNAL_STORAGE from plugin.xml.

Testing

Exec Local test with cordova-paramedic.
All tests passed with Pixel 5 API 30 and Pixel 5 API 33.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

README.md Outdated Show resolved Hide resolved
@breautek breautek added this to the 8.x milestone Jan 23, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@knight9999 knight9999 merged commit 4cd85f3 into apache:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants