Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): FileError on a content resolveLocalFileSystemURL #534

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

grassick
Copy link
Contributor

@grassick grassick commented Aug 4, 2022

Platforms affected

Android

Motivation and Context

This solves issue #525 which is a serious problem.

Closes #525

Description

This implements the fix described in #525 (comment)

Testing

I tested locally, pushed to production. Approximately 1000 installs working with no issues.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek requested a review from erisu August 7, 2022 01:41
@breautek breautek added this to the 7.0.1 Patch milestone Aug 7, 2022
@erisu
Copy link
Member

erisu commented Aug 9, 2022

Was this tested against both use cases of using either http/https and file scheme?

@HarelM
Copy link

HarelM commented Sep 13, 2022

Is there any way for me to help push this forward?
I haven't tested this with https, only with "default" capacitor configurations which is http and localhost.

@realtebo
Copy link

Please, fix this ASAP, because it's blocking some new projects

@erisu erisu changed the title (android) Fix issue #525 fix(android): FileError on a content resolveLocalFileSystemURL Jul 4, 2023
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 0bd76c5 into apache:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@7.0.0 resolveLocalFileSystemURL a content uri get a FileError 
5 participants