Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eslint): use cordova-eslint #122

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

timbru31
Copy link
Member

Ref apache/cordova#142
Ref apache/cordova#4

Depends on #120, therefor WIP

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

.eslintrc.yml Outdated Show resolved Hide resolved
tests/.eslintrc.yml Outdated Show resolved Hide resolved
@erisu
Copy link
Member

erisu commented Mar 26, 2020

I see that there are two .eslintrc.yml files.

  • <root>/.eslintrc.yml
  • <root>/tests/.eslintrc.yml

You can consolidate them into one file.

  • <root>/.eslintrc.yml
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

root: true
extends: '@cordova/eslint-config/browser'

overrides:
  - files: [tests/**/*.js]
    extends: '@cordova/eslint-config/node-tests'

@timbru31 timbru31 force-pushed the feat/adds-eslint-config branch from e6da846 to 07eb37c Compare March 26, 2020 14:45
@timbru31 timbru31 force-pushed the feat/adds-eslint-config branch from 07eb37c to 339d701 Compare March 26, 2020 14:46
@timbru31 timbru31 marked this pull request as ready for review March 26, 2020 14:46
@timbru31 timbru31 changed the title WIP: refactor(eslint): use cordova-eslint refactor(eslint): use cordova-eslint Mar 26, 2020
@timbru31 timbru31 merged commit 719038d into master Mar 26, 2020
@timbru31 timbru31 deleted the feat/adds-eslint-config branch March 26, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants