-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve npm ignore list #809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 89.48% 89.48%
=======================================
Files 48 48
Lines 2234 2234
=======================================
Hits 1999 1999
Misses 235 235 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add the two .eslint, .travis, .ratignore, too. IMO not required for the end user
@timbru31 Note the first line. It ignores all dotfiles. |
Oh indeed, I've missed that in the diff. |
= BEFORE = npm notice package size: 105.7 kB npm notice unpacked size: 487.6 kB npm notice total files: 86 = AFTER = npm notice package size: 88.3 kB npm notice unpacked size: 394.7 kB npm notice total files: 66
Motivation and Context
Decrease production package size
Description
BEFORE
npm notice package size: 105.7 kB
npm notice unpacked size: 487.6 kB
npm notice total files: 86
AFTER
npm notice package size: 88.3 kB
npm notice unpacked size: 394.7 kB
npm notice total files: 66
Testing
npm t
Checklist