Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve npm ignore list #809

Merged
merged 1 commit into from
Oct 30, 2019
Merged

chore: improve npm ignore list #809

merged 1 commit into from
Oct 30, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 29, 2019

Motivation and Context

Decrease production package size

Description

BEFORE
npm notice package size: 105.7 kB
npm notice unpacked size: 487.6 kB
npm notice total files: 86

AFTER
npm notice package size: 88.3 kB
npm notice unpacked size: 394.7 kB
npm notice total files: 66

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 10.0.0 milestone Oct 29, 2019
@erisu erisu requested a review from raphinesse October 29, 2019 03:51
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #809 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          48       48           
  Lines        2234     2234           
=======================================
  Hits         1999     1999           
  Misses        235      235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d268d...adf311a. Read the comment docs.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add the two .eslint, .travis, .ratignore, too. IMO not required for the end user

.npmignore Show resolved Hide resolved
.npmignore Outdated Show resolved Hide resolved
@raphinesse
Copy link
Contributor

raphinesse commented Oct 29, 2019

We should probably add the two .eslint, .travis, .ratignore, too. IMO not required for the end user

@timbru31 Note the first line. It ignores all dotfiles.

@timbru31
Copy link
Member

We should probably add the two .eslint, .travis, .ratignore, too. IMO not required for the end user

@timbru31 Note the first line. It ignores all dotfiles.

Oh indeed, I've missed that in the diff.

= BEFORE =
npm notice package size:  105.7 kB
npm notice unpacked size: 487.6 kB
npm notice total files:   86

= AFTER =
npm notice package size:  88.3 kB
npm notice unpacked size: 394.7 kB
npm notice total files:   66
@erisu erisu merged commit 1da0c20 into apache:master Oct 30, 2019
@erisu erisu deleted the v10-npm-ignore branch November 1, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants