Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) Simplify Cordova.podspec #892

Closed
wants to merge 1 commit into from

Conversation

sushichop
Copy link

@sushichop sushichop commented Jun 9, 2020

Platforms affected

iOS

Motivation and Context

I want to simplify Cordova.podspec since its setting is redundant(require_arc is duplicated).
I think this PR is preferable to ease podspec maintenance.

Description

This PR sets require_arc only once.

Testing

I executed pod lib lint at my local machine using CocoaPods 1.9.5.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #892 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1676     1676           
=======================================
  Hits         1247     1247           
  Misses        429      429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062b91d...a2c80e9. Read the comment docs.

@erisu
Copy link
Member

erisu commented Oct 6, 2021

#1154 has superseded this PR so I will be closing out this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants