Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: add & use fs-extra w/ fixes #847

Merged
merged 2 commits into from
May 20, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 16, 2020

Motivation, Context & Description

  • Add fs-extra dependency
  • Replace fs usage with fs-extra
  • Replace test spec xml generating logic and use pre-made xml test fixtures. Lower the amount of call mocks with actual tool usage for improved testing.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change

@erisu erisu added this to the 6.0.0 milestone May 16, 2020
@erisu erisu requested review from dpogue, timbru31 and NiklasMerz May 16, 2020 14:06
@erisu erisu force-pushed the breaking/use-fs-extra branch from 8e6dbb1 to d96a131 Compare May 19, 2020 01:28
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #847 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1821     1821           
=======================================
  Hits         1355     1355           
  Misses        466      466           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.42% <100.00%> (ø)
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.45% <100.00%> (ø)
bin/templates/scripts/cordova/lib/Podfile.js 73.58% <100.00%> (ø)
bin/templates/scripts/cordova/lib/PodsJson.js 95.04% <100.00%> (ø)
bin/templates/scripts/cordova/lib/build.js 50.76% <100.00%> (ø)
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.20% <100.00%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 82.05% <100.00%> (ø)
bin/templates/scripts/cordova/lib/projectFile.js 94.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae6a86...d96a131. Read the comment docs.

@timbru31
Copy link
Member

Replace test spec xml generating logic and use pre-made xml test fixtures. Lower the amount of call mocks with actual tool usage for improved testing.

Very nice!

@erisu erisu merged commit b9265b8 into apache:master May 20, 2020
@erisu erisu deleted the breaking/use-fs-extra branch May 20, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants