Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use node internal modules & replace fs-extra with node:fs #273

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 26, 2024

Platforms affected

n/a

Motivation and Context

Modernaize code

Description

  • Use Node Internal Modules node:*
  • Replace fs-extra with node:fs
  • Improve PackageJsonParser testing

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d5ad929) to head (12335e1).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          656       659    +3     
=========================================
+ Hits           656       659    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu force-pushed the refactor/use-node-internal-modules branch from f71ebba to 12335e1 Compare April 17, 2024 06:02
@erisu erisu marked this pull request as ready for review April 17, 2024 06:02
@erisu erisu requested a review from dpogue April 17, 2024 06:02
lib/PackageJsonParser.js Dismissed Show dismissed Hide dismissed
@erisu erisu merged commit da60500 into apache:master Apr 17, 2024
7 checks passed
@erisu erisu deleted the refactor/use-node-internal-modules branch April 17, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants