Skip to content

Commit

Permalink
ci: Set up CodeQL analysis w/ fix (#276)
Browse files Browse the repository at this point in the history
* ci: Set up CodeQL analysis
* chore(ql): resolve js/unused-local-variable
* ci(codeql): ignore generated cordova.js
  • Loading branch information
erisu authored Apr 17, 2024
1 parent abe901b commit d5ad929
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,27 @@ jobs:
node --version
npm --version
# "bin/templates/platform_www/cordova.js" is ignored because it is a generated file.
# It contains mixed content from the npm package "cordova-js" and "./cordova-js-src".
# The report might not be resolvable because of the external package.
# If the report is related to this repository, it would be detected when scanning "./cordova-js-src".
- uses: github/codeql-action/init@v3
with:
languages: javascript
queries: security-and-quality
config: |
paths-ignore:
- coverage
- node_modules
- bin/templates/platform_www/cordova.js
- name: npm install and test
run: npm cit
env:
CI: true

- uses: github/codeql-action/analyze@v3

- uses: codecov/codecov-action@v4
if: success()
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/

const { system, osInfo } = require('systeminformation');
const electron = require

module.exports = {
getSampleInfo: async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
var argscheck = require('cordova/argscheck');
var channel = require('cordova/channel');
var exec = require('cordova/exec');
var cordova = require('cordova');

channel.createSticky('onCordovaInfoReady');
// Tell cordova channel to wait on the CordovaInfoReady event
Expand Down

0 comments on commit d5ad929

Please sign in to comment.