Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set up CodeQL analysis w/ fixes #1711

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented May 9, 2024

Motivation and Context

CodeQL scanning in CI can help identify bugs and security issues with the library.

Description

  • Added CodeQL scanning with default options as part of CI.
  • Include fixes

Testing

  • Ran this in my fork, confirmed that CodeQL results showed up under security scanning
  • Applied some small fixes

Checklist

  • I've run the tests to see all new and existing tests pass

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (b773ae4) to head (ebab8ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1711      +/-   ##
==========================================
- Coverage   72.35%   72.15%   -0.20%     
==========================================
  Files          23       23              
  Lines        1834     1839       +5     
==========================================
  Hits         1327     1327              
- Misses        507      512       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu requested a review from dpogue May 10, 2024 07:01
@erisu erisu merged commit ed8e5d2 into apache:master May 13, 2024
11 checks passed
@erisu erisu deleted the ci/gha-codeql branch May 13, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants