Document interaction between peek and filter iterator #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I could not resolve the conflicts from here, I committed this directly to git master with @benjamin-confino as the author. TY for you patience! Closing. |
|
@garydgregory No worries, and thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.apache.org/jira/browse/COLLECTIONS-856
This documents the interaction between a peeking iterator and a filtering iterator; that if you call
peek()orelement(),fill()will find the next predicate approved element from the underlying filtering iterator, stash it inslot, ensuring it will be returned in the future even if the object changes and no longer matches the predicate.(This PR also removes an incorrect line saying
element()will return null if the underlying iterator is exhausted)