-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add partitionByChunkSize method in CollectionUtils #269
base: master
Are you sure you want to change the base?
Conversation
An empty collection shouldn't throw an exception it should just return an empty list... |
Thanks for the suggestion. Fixed it as suggested now. |
There are a lot of shorter ways to do this using Java 8 features: https://stackoverflow.com/questions/30995763/java-8-partition-list |
@garydgregory Thanks a lot for the suggestion. Fixed it now using Java 8 features as suggested. Please let me know in case of any other comments or better suggestions. Thanks again. |
@ramananravi |
@garydgregory Are you referring to the method name partitionByChunkSize? The reason for keeping this name is to keep this in sync with ListUtils.partition. Just to add, since partitionByNumOfChunks could be an extended version of this, kept this as partitionByChunkSize instead of just partition. |
@kinow @garydgregory Got some quick questions since this is my first contribution to this repo.
|
I'll take a look on Friday. |
Any updates on this? Also, in general, what's the PR merge and release cycle? Thanks in advance. |
Hi @ramananravi |
@garydgregory thanks a lot for the explanation and sorry for the follow-up. Just wanted to know how the merge and release cycle works, just to plan things from my side accordingly. This helps. Thanks again for your time and support on this. |
Merging from GitHub is done after a review by an Apache committer like
myself based on that person's available time, not much ATM, you might have
heard of issues with Log4j.
Releasing is more complex and you can get an idea under the "GENERAL
INFORMATION" section in the left bottom menu of
https://commons.apache.org/proper/commons-collections/
Gary
…On Thu, Dec 16, 2021 at 11:00 AM ramananravi ***@***.***> wrote:
@garydgregory <https://github.com/garydgregory> thanks a lot for the
explanation and sorry for the follow-up. Just wanted to know how the merge
and release cycle works, just to plan things from my side accordingly. This
helps. Thanks again for your time and support on this.
—
Reply to this email directly, view it on GitHub
<#269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJB6N2HBND3QMSHIEZGLLDURIELHANCNFSM5I7NZUYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@garydgregory - extremely sorry for the follow-up. Please let me know if there are any updates on this? Thanks in advance. |
@ramananravi If you will fix the conflicting changes, I'll take another look and see if we can get this merged into the main branch. |
@Claudenw - fixed as suggested. Please help check things and let me know in case of any further questions or comments. Thanks in advance. |
No description provided.