Add test cases for indexOf and contains method of ArrayUtils class #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiFromAjay
changed the title
kinow
reviewed
Feb 9, 2021
There was a problem hiding this comment.
I'm not sure how to review this one. The tests are simple, nothing wrong with the code. But I don't recall why we copied this class from Lang, instead of adding a dependency that's shaded (as we did in some other component I think?).
If there are tests in Lang, also not sure if we need/should duplicate them here. 🤔
Thanks for the PR anyway @HiFromAjay 👍
|
@kinow Any reason not to merge this? Or should we just close the pull request? |
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases are adapted from https://github.com/apache/commons-lang/blob/master/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java