Update Keyspace/Table name in prepared Query statement #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylwiaszunejko
force-pushed
the
keyspace_table
branch
from
0354152 to
5644ec0
Compare
avelanarius
reviewed
Jul 12, 2023
sylwiaszunejko
force-pushed
the
keyspace_table
branch
from
5644ec0 to
29547f4
Compare
sylwiaszunejko
changed the title
sylwiaszunejko
force-pushed
the
keyspace_table
branch
2 times, most recently
from
85d3da3 to
f420b60
Compare
sylwiaszunejko
force-pushed
the
keyspace_table
branch
2 times, most recently
from
a22ba29 to
9cda9c0
Compare
avelanarius
reviewed
Jul 17, 2023
sylwiaszunejko
force-pushed
the
keyspace_table
branch
2 times, most recently
from
6c946c3 to
0580053
Compare
martin-sucha
suggested changes
Jul 20, 2023
There was a problem hiding this comment.
Thank you for the pull request!
The change looks good to me in general, I added just one comment regarding error handling in the test.
Could you please also update the AUTHORS and CHANGELOG.md files as per CONTRIBUTING.md?
sylwiaszunejko
force-pushed
the
keyspace_table
branch
2 times, most recently
from
9dfe898 to
9760902
Compare
Previously TokenAwarePolicy always used Keyspace explicitly set in cluster.Keyspace regardless of the keyspace in the Query. Now after preparing statement Keyspace and Table names are transferred to the Query and it can make use of that. Fixes: apache#1621
sylwiaszunejko
force-pushed
the
keyspace_table
branch
from
9760902 to
65f29c8
Compare
martin-sucha
approved these changes
Jul 21, 2023
sylwiaszunejko
added a commit
to sylwiaszunejko/scylla-bench
that referenced
this pull request
Aug 9, 2023
Setting the keyspace explicitly was done to workaround the following bug: apache/cassandra-gocql-driver#1621 After fixing this bug it is not necessary anymore. (PR fixing it: apache/cassandra-gocql-driver#1714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
gocql.TokenAwareHostPolicyalways used keyspace explicitly specified in.KeyspaceinClusterConfigregardless of the keyspace in the Query. This would mean that the token awareness feature would not work properly if the user did not specify.KeyspaceinClusterConfigor did a query to a different keyspace.This PR introduces transferring Keyspace and Table names to the Query from the PREPARED response and updating information about that every time this information is received. After this change, the token awareness feature can work properly without user having to specify a keyspace in
ClusterConfig.I created automated integration test (
keyspace_table_test.go) on 3 nodes cluster.Fixes: #1621