ensure framer is not nil before accessing customPayload #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burkad01
changed the title
|
@martin-sucha Is there any way we can get this very small QOL change merged? This bug has existed for nearly 3 years now. If you need an updated PR or something, let me know and I'll throw one together in 2 seconds. |
|
Thanks for the nudge. This has slipped through the cracks, sorry about that. Looks good to me. Merged. |
|
Thanks, @martin-sucha ! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iter.GetCustomPayload() causes a nil panic if an error occurs on the cassandra query as iter.framer is nil. This PR adds a nil check of the framer before accessing customPayload and returns nil in the case where the framer is nil. This is similar to how Warnings() function works.