Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yaml] propogate error_handling to windowing composite config #33443

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[yaml] propogate error_handling to windowing composite config #33443

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bf559
[yaml] propogate error_handling to windowing composite config
Polber Dec 23, 2024
5f0a0d3
address comments
Polber Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdks/python/apache_beam/yaml/yaml_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,9 @@ def preprocess_windowing(spec):
'transforms': [modified_spec] + windowing_transforms,
'input': spec['input'],
'output': modified_spec['__uuid__'],
'config': {
'error_handling': spec.get('config').get('error_handling', None)
Polber marked this conversation as resolved.
Show resolved Hide resolved
} or {},
Polber marked this conversation as resolved.
Show resolved Hide resolved
'__line__': spec['__line__'],
'__uuid__': spec['__uuid__'],
}
Expand Down Expand Up @@ -805,6 +808,9 @@ def preprocess_windowing(spec):
'name': spec.get('name', None) or spec['type'],
'transforms': [modified_spec] + windowing_transforms,
'output': windowed_outputs,
'config': {
Polber marked this conversation as resolved.
Show resolved Hide resolved
'error_handling': spec.get('config').get('error_handling', None)
} or {},
'__line__': spec['__line__'],
'__uuid__': spec['__uuid__'],
}
Expand Down
Loading