Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rag chunking embedding #33364

Merged
merged 11 commits into from
Dec 17, 2024
Merged

Conversation

claudevdm
Copy link
Contributor

Add rag types, chunking and huggingface embeddings.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm force-pushed the rag-chunking-embedding branch 4 times, most recently from 2c56233 to ba37c66 Compare December 12, 2024 20:50
@claudevdm
Copy link
Contributor Author

R: @damccorm

@claudevdm claudevdm marked this pull request as ready for review December 12, 2024 20:54
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm claudevdm force-pushed the rag-chunking-embedding branch from ba37c66 to f0fd82e Compare December 12, 2024 21:18
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but mostly they are minor - thanks!

sdks/python/apache_beam/ml/rag/chunking/langchain.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/rag/chunking/langchain.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/rag/embeddings/huggingface.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/rag/types.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/rag/types.py Show resolved Hide resolved
sdks/python/apache_beam/ml/transforms/base.py Show resolved Hide resolved
sdks/python/apache_beam/ml/transforms/base.py Outdated Show resolved Hide resolved
@claudevdm claudevdm force-pushed the rag-chunking-embedding branch from f0fd82e to 60f01f3 Compare December 13, 2024 18:06
@claudevdm claudevdm force-pushed the rag-chunking-embedding branch from 87c452f to 13f3160 Compare December 13, 2024 20:30
@damccorm
Copy link
Contributor

Minor (but useful) note - when you force push a rebase, it removes my ability to see the diff between what I reviewed previously and the current state

image

So generally, please prefer just layering on additional commits in the PR and we can squash/merge at the end. Not really anything better about this workflow other than GitHub supports it better

@claudevdm claudevdm force-pushed the rag-chunking-embedding branch from 13f3160 to 9637269 Compare December 13, 2024 21:03
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One more minor comment, otherwise this LGTM

sdks/python/apache_beam/ml/rag/embeddings/huggingface.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/ml/transforms/base.py Show resolved Hide resolved
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 82.12291% with 32 lines in your changes missing coverage. Please review.

Project coverage is 57.41%. Comparing base (d9092a5) to head (9637269).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ks/python/apache_beam/ml/rag/chunking/langchain.py 51.35% 18 Missing ⚠️
...ython/apache_beam/ml/rag/embeddings/huggingface.py 68.42% 6 Missing ⚠️
sdks/python/apache_beam/ml/transforms/base.py 91.22% 5 Missing ⚠️
...pache_beam/ml/transforms/embeddings/huggingface.py 0.00% 2 Missing ⚠️
sdks/python/apache_beam/ml/rag/chunking/base.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33364      +/-   ##
============================================
+ Coverage     57.40%   57.41%   +0.01%     
  Complexity     1475     1475              
============================================
  Files           973      978       +5     
  Lines        154794   154935     +141     
  Branches       1076     1076              
============================================
+ Hits          88854    88959     +105     
- Misses        63737    63773      +36     
  Partials       2203     2203              
Flag Coverage Δ
python 81.25% <82.12%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM. The failing precommit seems to be related to flink, not this PR, so not blocking on that

@damccorm damccorm merged commit c5a5be5 into apache:master Dec 17, 2024
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants