Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Java Tests GitHub workflow #33354

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

damondouglas
Copy link
Contributor

This PR closes #33343 with the following changes:

  • Remove Wordcount Dataflow runner step
  • Remove google-github-actions/auth@v1 step

See code comments on this PR for contextual rationale for why these are proposed for removal.

See https://github.com/apache/beam/actions/runs/12266911887 for execution outcome of the workflow at this PR's branch.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Dec 11, 2024
@@ -152,46 +127,3 @@ jobs:
with:
name: java_wordcount_direct_runner-${{matrix.os}}
path: examples/java/build/reports/tests/integrationTest

java_wordcount_dataflow:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have GitHub workflow that test Java WordCount on Dataflow. It was skipped for so long and seems just another thing to maintain in our codebase.

@@ -44,26 +39,6 @@ env:
GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
jobs:
check_gcp_variables:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR proposes removal of the Dataflow WordCount Job, we do not need this check_gcp_variables Job.

@damondouglas damondouglas marked this pull request as ready for review December 11, 2024 18:37
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damondouglas damondouglas changed the title Java rm static gcp creds Clean up Java Tests GitHub workflow Dec 11, 2024
@damondouglas damondouglas merged commit f92dde1 into master Dec 13, 2024
9 checks passed
@damondouglas damondouglas deleted the java-rm-static-gcp-creds branch December 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Clean up Java Tests workflow
2 participants