Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32929] Add OrderedListState support to Prism. #33350

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Dec 11, 2024

Adds support for the OrderedListState to Prism.

  • Sorts values by VarInt Millis timestamp order on append.
  • Lookup values by range requests from SDK.
  • Handles known fixed leaf types as values (bools, doubles), varints, and length prefixed types.
    • If the type can be length prefixed, then Prism will do that for that coder.
    • Otherwise fails for unknown coders that can't be handled.
    • Runner side, Only OrderedListState needs to parse the individual values, so they can be manipulated, so the length function plumbing isn't otherwise necessary. It would not be difficult to extend this for all state types in the future, should it be required.

Note, must be submitted after #33337 because OrderedListState tests require OnWindowExpiration.

Fixes #32929.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@lostluck
Copy link
Contributor Author

R: @shunping @damondouglas

PTAL!

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damondouglas damondouglas self-requested a review December 16, 2024 17:57
Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment but LGTM.

sdks/go/pkg/beam/runners/prism/internal/engine/data.go Outdated Show resolved Hide resolved
@lostluck lostluck merged commit 8e1e124 into apache:master Dec 17, 2024
20 of 21 checks passed
@lostluck lostluck deleted the orderedListState branch December 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prism] Support OrderedListState
2 participants