Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of google-github-actions/auth@v1 #33338

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

damondouglas
Copy link
Contributor

This PR fixes #30527 removing an outdated pattern for authentication to Google Cloud platform. See full SBAR for situation, background, Assessment and recommendation.

See workflow run at the branch of this PR: https://github.com/apache/beam/actions/runs/12246491594


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review December 10, 2024 00:45
@github-actions github-actions bot added the build label Dec 10, 2024
@damondouglas damondouglas changed the title Fix beam post commit java io performance tests Remove the use of google-github-actions/auth@v1 Dec 10, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damondouglas
Copy link
Contributor Author

assign set of reviewers

@damondouglas
Copy link
Contributor Author

The PostCommit IO Performance check will fail in this PR because it is performed on the wrong branch. Please see https://github.com/apache/beam/actions/runs/12246491594 for the results based on this branch.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damondouglas damondouglas merged commit 76bcec0 into master Dec 10, 2024
5 of 10 checks passed
@damondouglas damondouglas deleted the fix-beam_PostCommit_Java_IO_Performance_Tests branch December 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PostCommit Java IO Performance Tests job is flaky
2 participants